-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e testing for mongo #1277
e2e testing for mongo #1277
Conversation
This is the line where the database is being dropped between tests. The integration tests, all call this function, since they call this fixture: @pytest.fixture
def database_with_default_encoders_and_model(test_db):
... |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
===========================================
- Coverage 80.33% 64.14% -16.20%
===========================================
Files 95 103 +8
Lines 6602 6941 +339
===========================================
- Hits 5304 4452 -852
- Misses 1298 2489 +1191
☔ View full report in Codecov by Sentry. |
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
- users.env | ||
command: sh -c "/scripts/mongo-init.sh" | ||
|
||
# # Dask Parallel Computation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this all be commented out?
Description
Add end-to-end testing for mongo.
The
test_cdc
is falling.This is probably due to a false assumption that the database is being reset on every iteration. However, this is not the case for integration testing, and the
test_index
is increasingly populated, resulting in failing assertions.For instance:
Related Issues
Checklist
make test
successfully?Additional Notes or Comments