Support openai>=1.1.2 #1260
Merged
Support openai>=1.1.2 #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
impv/openai-new-version
branch
4 times, most recently
from
18d8719 to
4702796
Compare
thejumpman2323
suggested changes
Nov 10, 2023
jieguangzhou
force-pushed
the
impv/openai-new-version
branch
from
4702796 to
4b08b0d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
+ Coverage 80.33% 80.65% +0.31%
==========================================
Files 95 97 +2
Lines 6602 6689 +87
==========================================
+ Hits 5304 5395 +91
+ Misses 1298 1294 -4
☔ View full report in Codecov by Sentry. |
blythed
reviewed
Nov 10, 2023
| f'{CASSETTE_DIR}/test_batch_translate_async.yaml', | ||
| filter_headers=['authorization'], | ||
| ) | ||
| @vcr.use_cassette() |
There was a problem hiding this comment.
We don't need this meta-data?
There was a problem hiding this comment.
I created
vcr = vcr.VCR(
path_transformer=lambda x: x + '.yaml',
match_on=('method', 'path'),
filter_headers=['authorization'],
cassette_library_dir=CASSETTE_DIR,
before_record_request=before_record_request,
before_record_response=before_record_response,
)
to handle this
There was a problem hiding this comment.
Aha -- gotcha -- I missed that. This is nice.
jieguangzhou
commented
Nov 10, 2023
Comment on lines
+28
to
+38
| # monkey patch vcr to make it work with upload binary data | ||
| def _make_vcr_request(httpx_request, **kwargs): | ||
| from vcr.request import Request as VcrRequest | ||
|
|
||
| try: | ||
| body = httpx_request.read().decode("utf-8") | ||
| except UnicodeDecodeError: | ||
| body = str(httpx_request.read()) | ||
| uri = str(httpx_request.url) | ||
| headers = dict(httpx_request.headers) | ||
| return VcrRequest(httpx_request.method, uri, body, headers) |
There was a problem hiding this comment.
In the latest version, when vcr decodes the uploaded binary file, an error occurs. We need to patch it here.
There was a problem hiding this comment.
We will get a error on decode for the binary data
jieguangzhou
commented
Nov 10, 2023
| ''' | ||
| VCR filter function to only record the PNG signature in the response. | ||
|
|
||
| This is necessary because the response is a PNG which can be quite large. | ||
| ''' | ||
| if 'body' not in response: |
There was a problem hiding this comment.
In the latest version, some responses lack the body field, which will cause an error in the following logic.
thejumpman2323
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1261
Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments