Refactor tests to run in parallel #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
test/parallel
branch
from
e27c0c6 to
2c9864d
Compare
3 tasks
jieguangzhou
force-pushed
the
test/parallel
branch
from
2c9864d to
f19af7f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 80.33% 80.70% +0.36%
==========================================
Files 95 97 +2
Lines 6602 6691 +89
==========================================
+ Hits 5304 5400 +96
+ Misses 1298 1291 -7
☔ View full report in Codecov by Sentry. |
jieguangzhou
requested review from
blythed,
thejumpman2323 and
fnikolai
and removed request for
blythed and
thejumpman2323
thejumpman2323
suggested changes
Nov 7, 2023
test/integration/test_dask.py
Outdated
| @@ -58,6 +58,11 @@ def test_taskgraph_futures_with_dask( | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(not torch, reason='Torch not installed') | |||
| @pytest.mark.parametrize( | |||
| 'local_dask_client, test_db', | |||
| [('test_insert_with_dask', 'test_insert_with_dask')], | |||
There was a problem hiding this comment.
(test_insert_with_distributed, test_insert_with_non_distributed)
There was a problem hiding this comment.
I think we should use the same database name here, right?
jieguangzhou
force-pushed
the
test/parallel
branch
from
f19af7f to
b681245
Compare
blythed
reviewed
Nov 8, 2023
blythed
approved these changes
Nov 8, 2023
jieguangzhou
force-pushed
the
test/parallel
branch
from
b681245 to
247932a
Compare
jieguangzhou
commented
Nov 8, 2023
jieguangzhou
force-pushed
the
test/parallel
branch
2 times, most recently
from
bbe7087 to
69afa6a
Compare
thejumpman2323
suggested changes
Nov 10, 2023
3 tasks
jieguangzhou
force-pushed
the
test/parallel
branch
from
69afa6a to
b1e6a43
Compare
thejumpman2323
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#671
Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments