Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isort dependency #1251

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented Nov 7, 2023

Looks like isort was removed as a dependency since ruff was used with isort config, but somehow it got back in the dependencies.

Description

Removes isort from dependencies and Makefile.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@aminalaee aminalaee force-pushed the remove-isort-dependency branch from 80df064 to cd78876 Compare November 7, 2023 14:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (cd78876) 80.62%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
+ Coverage   80.33%   80.62%   +0.28%     
==========================================
  Files          95       97       +2     
  Lines        6602     6684      +82     
==========================================
+ Hits         5304     5389      +85     
+ Misses       1298     1295       -3     
Files Coverage Δ
superduperdb/base/config.py 100.00% <ø> (ø)
superduperdb/components/model.py 93.66% <100.00%> (+11.00%) ⬆️
superduperdb/ext/openai/model.py 96.09% <ø> (+0.64%) ⬆️
superduperdb/ext/torch/model.py 76.80% <ø> (ø)
superduperdb/misc/superduper.py 76.25% <ø> (ø)
superduperdb/base/build.py 65.85% <66.66%> (-1.65%) ⬇️
superduperdb/base/logger.py 86.95% <80.00%> (-3.05%) ⬇️
superduperdb/cli/serve.py 39.28% <50.00%> (+4.28%) ⬆️
superduperdb/cli/stack.py 55.55% <55.55%> (ø)
superduperdb/components/stack.py 41.53% <41.53%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jieguangzhou jieguangzhou requested a review from fnikolai November 7, 2023 15:28
Copy link
Collaborator

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jieguangzhou jieguangzhou merged commit 5150668 into superduper-io:main Nov 7, 2023
2 checks passed
@aminalaee aminalaee deleted the remove-isort-dependency branch November 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants