Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device fallback in serialization #1240

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix device fallback in serialization #1240

merged 1 commit into from
Nov 7, 2023

Conversation

thejumpman2323
Copy link
Contributor

@thejumpman2323 thejumpman2323 commented Nov 4, 2023

Description

fix #1158

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (3cad92b) 80.44%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   80.33%   80.44%   +0.10%     
==========================================
  Files          95       97       +2     
  Lines        6602     6683      +81     
==========================================
+ Hits         5304     5376      +72     
- Misses       1298     1307       +9     
Files Coverage Δ
superduperdb/base/config.py 100.00% <ø> (ø)
superduperdb/components/model.py 93.66% <100.00%> (+11.00%) ⬆️
superduperdb/ext/openai/model.py 96.09% <ø> (+0.64%) ⬆️
superduperdb/ext/torch/model.py 76.80% <ø> (ø)
superduperdb/misc/serialization.py 85.86% <100.00%> (+0.92%) ⬆️
superduperdb/misc/superduper.py 76.25% <ø> (ø)
superduperdb/base/build.py 65.85% <66.66%> (-1.65%) ⬇️
superduperdb/base/logger.py 86.95% <80.00%> (-3.05%) ⬇️
superduperdb/cli/serve.py 39.28% <50.00%> (+4.28%) ⬆️
superduperdb/cli/stack.py 55.55% <55.55%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blythed
Copy link
Collaborator

blythed commented Nov 5, 2023

Do we need a unit-test?

@thejumpman2323
Copy link
Contributor Author

thejumpman2323 commented Nov 6, 2023

@blythed I don't think unit test is possible on ci as ci only have one device -- ok but we can have something that runs on Mac M1 -- or we could mock this?

@thejumpman2323 thejumpman2323 merged commit 36644ae into superduper-io:main Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Preferred devices mixes up devices on Mac M1
4 participants