Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability and improve quality of core code #408

Closed
7 tasks done
rec opened this issue Jul 11, 2023 · 3 comments
Closed
7 tasks done

Usability and improve quality of core code #408

rec opened this issue Jul 11, 2023 · 3 comments
Assignees
Labels
epic 📉 technical debt Things that slow us down

Comments

@rec
Copy link
Contributor

rec commented Jul 11, 2023

Why?

We have a large amount of fairly fresh code, much of which is not covered by any unit test and is only partly documented.

Before launch, we need to review the core code for problems, document, add types, and increase test coverage.

How?

Each Python file eventually needs to:

  • Be reviewed for errors and issues
  • Be documented (doc comments for functions, classes, members, methods, and parameters)
  • Have "good" typing (perfect typing is impractical)
  • Have "good" test coverage (see above)

What

The plan is to start with superduperdb/core and continue down from there.

The rough order is:

  • serialization
  • artifacts
  • containers
  • documents
  • ?

Sub-issues

@nenb
Copy link
Contributor

nenb commented Aug 29, 2023

I'm going to suggest also tracking mypy-related issues here as well. If this is not appropriate please move elsewhere.

Current mypy issues:

@rec rec mentioned this issue Sep 15, 2023
@blythed blythed changed the title Improve quality of core code Usability and improve quality of core code Sep 16, 2023
@blythed blythed assigned blythed and unassigned rec Oct 6, 2023
@blythed
Copy link
Collaborator

blythed commented Oct 16, 2023

New issues:

  • configure which collections are in use, and move cdc configuration back to the top level (no CDC_COLLECTION_LOCKS).

@blythed
Copy link
Collaborator

blythed commented Nov 8, 2023

Addressed by #1243

@blythed blythed closed this as completed Nov 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in superduper-open-source Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic 📉 technical debt Things that slow us down
Projects
Status: Done
Development

No branches or pull requests

3 participants