Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code quality #36

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Some code quality #36

merged 3 commits into from
Sep 19, 2023

Conversation

nicopap
Copy link

@nicopap nicopap commented Sep 19, 2023

  • Use QueryItem<Self::Query> instead of <Self::Query as WorldQuery>::Item<'_> (I think I might have missed some instances
  • use PartialEq derive over manual impl
  • use a reduce over a fairly complex loop setup in batch_and_prepare_render_phase
  • Move the construction of BatchMeta from batch_and_prepare_render_phase to BatchMeta::new
  • Make the BatchMeta fields private.
  • Call render_range in render instead of copy/pasting the code.
  • Replace the odd handling of arrays in SetMesh2dBindGroup::render

@nicopap
Copy link
Author

nicopap commented Sep 19, 2023

Previous discussion in #35. Closed due to some GH bug

@superdump superdump merged commit 5f4dd4c into superdump:batching Sep 19, 2023
@nicopap nicopap deleted the cleanup-batch-2 branch September 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants