Classlib: Put 'protect' in PauseStreams (update state on error) #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamshark70
added
bug
telephon
reviewed
Nov 28, 2021
| *new { arg func, clock; | ||
| ^super.new(Routine(func), clock) | ||
| var new = super.new(Routine({ |inval| |
There was a problem hiding this comment.
could you move the Routine in a new line?
|
Thanks! I've tested your branch, all works well. |
telephon
approved these changes
Nov 28, 2021
|
Thanks! Is this good to be merged, then? |
There's one pending formatting change, which I can do within an hour or so. |
|
OK, formatting change is done. |
|
sorry @jamshark70, lost track of it – kooks good now! (feel free to ping me any time, I sometimes don't look at github for a while) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes #5597.
Pprotectis not sufficient to catch errors thrown while playing an event produced by a pattern. In this case, state variables had not been updated to reflect a PauseStream's new non-playing state.Julian had the good idea to embed
protectinto the Routine being managed by a PauseStream (I hadn't thought of this!), but an earlier version didn't apply this consistently.This version introduces it into
PauseStream,Task, andEventStreamPlayer.Types of changes
To-do list
Under #5623, Julian had proposed some test cases, and volunteered to turn those into formal unit tests. So this PR does not include unit tests directly, but they will follow.