Shorten pull request template #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the branch you PR against have any effect on which template is shown? If so, should probably rebase this on 3.10. [Also remember for future commits to use [skip ci]]. |
mossheim
suggested changes
Jan 23, 2019
always default branch: "Templates are available to collaborators when they are merged into the repository's default branch." |
mossheim
approved these changes
Jan 24, 2019
|
Initially I didn't like that we were using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've found that the PR template, while made with great intentions, is pretty awkward to use on a daily basis. there's too much text, and it's just kinda cluttered and overwhelming. i feel that it can be made way shorter, reducing it to just the gist of the process, and still provide most of the necessary slots for a newcomer to fill out. any ambiguities or missing details can be easily worked out through regular conversation.
i'm aware some might object to the amount of detail i'm removing. my answer is that i think it's better to err on the side of brevity when it comes to these templates.