Topic fix as score offset expansion #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the score function correctly expands the timing values that the usual play function expands. This fixes supercollider#3543
|
what issue does this fix? thanks. |
|
Fixes #3543 |
mossheim
reviewed
Mar 1, 2018
testsuite/classlibrary/TestScore.sc
Outdated
| var events, score, onsetTimes; | ||
| events = [(x: 0, lag: 0.5), (x: 1, dur: 0.5), (x: 2, lag: 0.5)]; | ||
| score = Pseq(events).asScore(3); | ||
| onsetTimes = score.score.drop(1).postcs.select { |x| x[2] == \default }.collect { |x| x.first }; |
There was a problem hiding this comment.
can you please remove the postcs from these tests?
There was a problem hiding this comment.
also, using collect(_.first) at the end might make it more readable. personally i think it would be clearest to break this into two lines with an extra variable
joshpar
approved these changes
Mar 4, 2018
joshpar
approved these changes
Mar 4, 2018
joshpar
approved these changes
Mar 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.