server plugins: Gendy*: fix initialization bug #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard is Gendy*_next_k(unit, 1), but that results in a behavior change that removes the first sample of output.
|
It's fine. It doesn't matter for a synthesis UGen, it can do what it wants. It would be a wrong fix if this were a filter UGen because it would be dropping data from the inputs. Here it's fine |
|
Can you comment on whether this is a correct mathematical model of how the Ctor sample works? #2322 (comment) |
|
Original bug confirmed, fix confirmed. Deadly bug that kills speakers and ear drums:
Nice work @snappizz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original bug is described here: http://new-supercollider-mailing-lists-forums-use-these.2681727.n2.nabble.com/Gendy-instability-td7627785.html
This is kind of an odd way of fixing the bug, and we should discuss it. The standard method would be to write
Gendy*_next_k(unit, 1), but that results in a behavior change that removes the first sample of output. Try running{Gendy1.ar}.plot(1e-3)and you'll see what I mean.