Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Clip NOVA functions should update unit-> variables #1702

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Plugins: Clip NOVA functions should update unit-> variables #1702

merged 1 commit into from
Nov 7, 2015

Conversation

jamshark70
Copy link
Contributor

Bug reported on the mailing list: kr inputs to an ar Clip unit produce a sawtooth wave when changed.

This is because the original author of the SIMD calculation functions (38f2d28) forgot to update the struct member variables with new data from the inputs, meaning that every subsequent control cycle would attempt to ramp to the new value.

(
/* Start the synth, everything is correct... */
a = {
    arg control = 0.2;
    Clip.ar(DC.ar(), control, 0.4);
}.scope;
)

/* Until I change the control value */
a.set(\control, 0.25);

/* At this point I hear and see high-pitched oscillation that's
samplerate-dependant. */

@jamshark70 jamshark70 added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: server plugins labels Oct 29, 2015
@jamshark70 jamshark70 added this to the 3.7.0 milestone Oct 29, 2015
crucialfelix added a commit that referenced this pull request Nov 7, 2015
Plugins: Clip NOVA functions should update unit-> variables
@crucialfelix crucialfelix merged commit 5ac428b into supercollider:master Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: server plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants