Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import boost-1.58 #1528

Merged

Conversation

timblechmann
Copy link
Contributor

and use official boost.endian

@scztt scztt added this to the 3.8 milestone Jun 7, 2015
@timblechmann timblechmann force-pushed the topic/updates-for-master branch 3 times, most recently from dbe6eb9 to aab54bf Compare July 7, 2015 03:48
@timblechmann timblechmann force-pushed the topic/updates-for-master branch from aab54bf to c69da82 Compare July 19, 2015 08:26
@timblechmann
Copy link
Contributor Author

ping

@scztt
Copy link
Contributor

scztt commented Jul 26, 2015

This should be for 3.8? We can pull once 3.7 is out, unless there are important 3.7 bugs that will be fixed by this.

@timblechmann
Copy link
Contributor Author

if master is not open for updates, why not create a 3.7 release branch? that's how we dealt with the release process in the past.

@scztt
Copy link
Contributor

scztt commented Jul 27, 2015

We can create a 3.7 branch any time - we've held off thus far to concentrate attention on locking down 3.7 fixes, with the intention that we would branch when there were changes that needed to be shared in the main repo and were important enough to justify branching. This is probably a good candidate for that branch, especially if you have further development work to do on top of this.

@timblechmann
Copy link
Contributor Author

4c8eb13 should be one part of the fix for #1635

@timblechmann
Copy link
Contributor Author

fwiw, it would be nice if this could at one point be merged, as it block some further changes (read: bug fixes) of supernova

@telephon
Copy link
Member

telephon commented Dec 6, 2015

@scztt @timblechmann is it defendable to do this for 3.7.0 or 3.7.x? I don't know enough about the consequences to be able to decide this.

@danstowell
Copy link
Member

make the 3.7 branch!!!!!!!!!!!!!!!!!!!!!!!!!

@crucialfelix
Copy link
Member

3.7 is made and pushed

On Sun, Dec 6, 2015 at 10:29 AM danstowell [email protected] wrote:

make the 3.7 branch!!!!!!!!!!!!!!!!!!!!!!!!!


Reply to this email directly or view it on GitHub
#1528 (comment)
.

@crucialfelix
Copy link
Member

Don't merge it to 3.7, there is no reason to introduce any risk, there is
nothing that the new boost fixes that is urgent.

On Sun, Dec 6, 2015 at 11:31 AM Chris Sattinger [email protected]
wrote:

3.7 is made and pushed

On Sun, Dec 6, 2015 at 10:29 AM danstowell [email protected]
wrote:

make the 3.7 branch!!!!!!!!!!!!!!!!!!!!!!!!!


Reply to this email directly or view it on GitHub
#1528 (comment)
.

@danstowell
Copy link
Member

This compiles fine for me, and SC boots and makes the noises I expect it to make.

I suggest merging this into master.

(Note: the title of the PR is a bit wrong, since Tim later updated this branch to boost-1.59.)

danstowell added a commit that referenced this pull request Dec 13, 2015
@danstowell danstowell merged commit 6c25a6e into supercollider:master Dec 13, 2015
@timblechmann timblechmann deleted the topic/updates-for-master branch March 18, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants