-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added missing error codes for AuthException #995
Conversation
Thanks for getting started on this one! Here is the JS PR for the same feature. If you could match the implementation as much as possible, that would be great! |
- Introduce api versioning - Change AuthErrorCode to ErrorCode
Applied adjustments to the logic from JS implementation:
Doubts:
PS. If the logic should match the JS implementation exactly, please let me know. If we are heading in that direction, I would appreciate guidance on the process of implementing new functionalities. Does this mean we always have to wait for the implementation in JS first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lawinski Thanks for the amazing work! This PR is awesome! I edited the code in a way that I think would be more aligned with the JS SDK and might be easier to maintain, but would love to hear what you think!
If the logic should match the JS implementation exactly, please let me know. If we are heading in that direction, I would appreciate guidance on the process of implementing new functionalities.
Generally yes. The closer the implementation is to the JS SDK, the easier to maintain, and also could avoid having to deviate the SDK from the JS one because of future changes that were not anticipated.
Does this mean we always have to wait for the implementation in JS first?
Also generally yes.
@dshukertjr I'm okay with the changes :) LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What kind of change does this PR introduce?
Add support for auth error codes
What is the current behavior?
There are no error code in auth exception
What is the new behavior?
Error codes added to AuthException