Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add linkedin_oidc OAuthProvider #791

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat: Add linkedin_oidc OAuthProvider #791

merged 3 commits into from
Jan 9, 2024

Conversation

Vinzent03
Copy link
Collaborator

What kind of change does this PR introduce?

feature

What is the new behavior?

Adds the linkedin_oidc OAuthProvider.

Additional context

@Vinzent03 Vinzent03 requested a review from dshukertjr January 7, 2024 19:56
dshukertjr
dshukertjr reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until now, when js SDK has a snake case enum value, we were converting them to camel case. I think we should keep the same pattern for consistency here as well. Would you be able to update the code so that this would work with camel case?

@Vinzent03 Vinzent03 changed the title feat: add linkedin_oidc OAuthProvider feat: Add linkedin_oidc OAuthProvider Jan 8, 2024
@Vinzent03 Vinzent03 requested a review from dshukertjr January 8, 2024 21:31
@dshukertjr dshukertjr merged commit 0966428 into main Jan 9, 2024
9 of 10 checks passed
@dshukertjr dshukertjr deleted the feat/linkedin_oidc branch January 9, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linkedin_oidc is not a supported provider for the signInWithOAuth method
2 participants
@Vinzent03 @dshukertjr