Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support custom access token #1073

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: Support custom access token #1073

merged 3 commits into from
Nov 11, 2024

Conversation

Vinzent03
Copy link
Collaborator

@Vinzent03 Vinzent03 commented Oct 30, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Passing a custom access token to supabase_flutter doesn't work. I noticed that the SupabaseClient.dispose() method didn't work with custom access token as well.

What is the new behavior?

The realtime reconnection logic is moved to the Supabase class and SupabaseAuth is only initialized when no custom accessToken is passed.

Additional context

close #1072

@Vinzent03 Vinzent03 changed the title fix: support custom access token fix: Support custom access token Oct 30, 2024
@Vinzent03 Vinzent03 requested a review from dshukertjr October 30, 2024 21:43
@dshukertjr
Copy link
Member

Thanks for this. I might not have the time to review it today, but will get to it as soon as possible!

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the massive delay on this one. Thanks for the fix!

@Vinzent03 Vinzent03 merged commit fc9ad2c into main Nov 11, 2024
6 checks passed
@Vinzent03 Vinzent03 deleted the fix/accessToken branch November 11, 2024 23:10
@gbaladi
Copy link

gbaladi commented Nov 12, 2024

@dshukertjr hi, is there any timetable that a new version of the client will be published with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supabase.initialize throws an AuthException when an accessToken is provided
3 participants