Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yet_another_json_isolate): Conditional export now works correctly with Dart 3.5+ #1048

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix(yet_another_json_isolate): Conditional export now works correctly with Dart 3.5+ #1048

merged 4 commits into from
Sep 30, 2024

Conversation

YumNumm
Copy link
Contributor

@YumNumm YumNumm commented Sep 28, 2024

What kind of change does this PR introduce?

Fix

What is the current behavior?

Supabase.initialize() doesn't work correctly on Dart 3.5+ with WASM Compiler

What is the new behavior?

Supabase.initialize() works!

Additional context

@YumNumm YumNumm marked this pull request as ready for review September 28, 2024 15:04
This was referenced Sep 28, 2024
Closed
Merged
@YumNumm YumNumm changed the title [yet_another_json_isolate] conditional export doesn't work correctly on Dart 3.5+ fix: [yet_another_json_isolate] conditional export doesn't work correctly on Dart 3.5+ Sep 28, 2024
@YumNumm YumNumm changed the title fix: [yet_another_json_isolate] conditional export doesn't work correctly on Dart 3.5+ Fix: [yet_another_json_isolate] conditional export doesn't work correctly on Dart 3.5+ Sep 28, 2024
@YumNumm YumNumm changed the title Fix: [yet_another_json_isolate] conditional export doesn't work correctly on Dart 3.5+ fix: (yet_another_json_isolate) conditional export doesn't work correctly on Dart 3.5+ Sep 28, 2024
@YumNumm YumNumm changed the title fix: (yet_another_json_isolate) conditional export doesn't work correctly on Dart 3.5+ fix(yet_another_json_isolate): Conditional export doesn't work correctly on Dart 3.5+ Sep 28, 2024
@dshukertjr dshukertjr changed the title fix(yet_another_json_isolate): Conditional export doesn't work correctly on Dart 3.5+ fix(yet_another_json_isolate): Conditional export now works correctly with Dart 3.5+ Sep 30, 2024
dshukertjr
dshukertjr approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks great!

@dshukertjr dshukertjr merged commit 6c80a74 into supabase:main Sep 30, 2024
13 checks passed
@YumNumm YumNumm deleted the fix/ya_json_isolate_conditional_export branch October 1, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[yet_another_json_isolate] conditional export doesn't work correctly on dart 3.5+
2 participants
@YumNumm @dshukertjr