fix: Support all mfa auth methods #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
changed the title
dshukertjr
reviewed
Sep 14, 2024
bdlukaa
reviewed
Sep 15, 2024
dshukertjr
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Not all mfa auth methods can be parsed.
What is the new behavior?
Add the rest of methods from here
Additional context
Just in case, is the auth team aware that the
MFAPhonehas different string values? 😅https://github.com/supabase/auth/blob/a6c18243b92b74798b6317e1c35c8a73bc3fd6e1/internal/models/factor.go#L81
and
https://github.com/supabase/auth/blob/a6c18243b92b74798b6317e1c35c8a73bc3fd6e1/internal/models/factor.go#L113
I have chosen
mfa/phonefor now.#966