ci: Fix app_links test #1006
Merged
ci: Fix app_links test #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
force-pushed
the
test/app_links
branch
from
bb59b5d to
7296a58
Compare
Vinzent03
force-pushed
the
test/app_links
branch
from
7296a58 to
274e19f
Compare
dshukertjr
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ci fix
What is the current behavior?
Since app_links v6.2.0 the test is broken.
What is the new behavior?
I remove the exact to check when app_links received the uri, because it highly depends on the version we are testing, since we still support old 3.5.0. Instead, I just way for 500ms, which should be enough.
Additional context
The commit, which "broke" the test: llfbandit/app_links@bb717cc
It's because the stream is now broadcast and doesn't emit the latest event when listening.