Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert database connection retries #120

Merged
merged 7 commits into from
Feb 11, 2021
Merged

fix: revert database connection retries #120

merged 7 commits into from
Feb 11, 2021

Conversation

w3b6x9
Copy link
Member

@w3b6x9 w3b6x9 commented Feb 10, 2021

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

A lot of :undefined.handle_message/4 is undefined errors.

What is the new behavior?

Hopefully, no more :undefined.handle_message/4 is undefined errors.

Additional context

See epgsql issue #253 and realtime issue #106 for context.

Database connection retrying might be the culprit that's causing :undefined.handle_message/4 is undefined errors. Will continue monitoring server logs to see if error resurfaces.

@w3b6x9 w3b6x9 marked this pull request as ready for review February 10, 2021 05:58
@w3b6x9 w3b6x9 requested a review from soedirgo February 10, 2021 06:15
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @w3b6x9!

@kiwicopple kiwicopple mentioned this pull request Feb 10, 2021
2 tasks
@w3b6x9 w3b6x9 merged commit af6344c into master Feb 11, 2021
@w3b6x9 w3b6x9 deleted the fix/db-retry-revert branch February 11, 2021 03:18
@github-actions
Copy link

🎉 This PR is included in version 0.10.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

w3b6x9 pushed a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants