Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix improper policy checking #1085

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Conversation

filipecabaco
Copy link
Contributor

@filipecabaco filipecabaco commented Jul 1, 2024

What kind of change does this PR introduce?

  • Presence had a bad check when tracking changes
  • JWT checking had a bad check and a broken test
  • Fixed some migrations to be less susceptible to errors on migrations
  • Added one connection to db_pool
  • Removed one connection from subcriber_pool_size

* Presence had a bad check when tracking changes
* JWT checking had a bad check and a broken test
* Fixed some migrations to be less susceptible to errors on migrations
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 8:11am

@filipecabaco filipecabaco requested review from chasers, abc3 and w3b6x9 July 1, 2024 16:31
lib/realtime_web/channels/realtime_channel.ex Outdated Show resolved Hide resolved
lib/realtime_web/channels/realtime_channel.ex Outdated Show resolved Hide resolved
@filipecabaco filipecabaco force-pushed the fix/improper-policy-checking branch from fcfab39 to e1e5523 Compare July 2, 2024 08:11
@filipecabaco filipecabaco merged commit d57b3cc into main Jul 2, 2024
4 checks passed
@filipecabaco filipecabaco deleted the fix/improper-policy-checking branch July 2, 2024 10:32
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.29.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

@fullstackwebdev
Copy link

this is broken code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants