Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configuration to include realtime config settings #92

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

w3b6x9
Copy link
Member

@w3b6x9 w3b6x9 commented Dec 19, 2020

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Loading JSON config file crashes SubscribersNotification process. See Issue #87 for more info.

What is the new behavior?

Loading JSON config file with "realtime" and "webhooks" doesn't crash SubscribersNotification process and keeps the server operating as usual.

Additional context

Areas of focus:

  • Extensibility - introduced a new pattern that makes it easier to add additional connectors to Configuration.
  • User warnings - immediately warns users of common mistakes with their JSON configuration file.

@github-actions
Copy link

🎉 This PR is included in version 0.9.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@w3b6x9 w3b6x9 deleted the config-file branch December 21, 2020 14:38
kiwicopple pushed a commit to kiwicopple/realtime that referenced this pull request Jun 9, 2021
w3b6x9 pushed a commit that referenced this pull request Nov 4, 2022
Deploy staging, add ewalrus aws->fly mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubscribersNotification process crashes when loading config from json file
2 participants