Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscribersNotification process crashes when loading config from json file #87

Closed
w3b6x9 opened this issue Dec 15, 2020 · 1 comment · Fixed by #92
Closed

SubscribersNotification process crashes when loading config from json file #87

w3b6x9 opened this issue Dec 15, 2020 · 1 comment · Fixed by #92
Labels
bug Something isn't working

Comments

@w3b6x9
Copy link
Member

w3b6x9 commented Dec 15, 2020

Bug report

Describe the bug

Loading config from a json file:

For example

{
  "webhooks": [
    {
      "events": "*",
      "config": {
          "endpoint": "https://webhook.site/93d0c185-5172-4c83-bf36-fa3c4dd02cee"
      }
    }
  ],
  "realtime": []
}

crashes the Realtime.SubscribersNotification process.

This is due to PR #76 not converting "realtime" config from json file to :realtime in Configuration module.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Create a config json file in the /server dir with something like:
{
  "webhooks": [
    {
      "events": "*",
      "config": {
          "endpoint": "https://webhook.site/93d0c185-5172-4c83-bf36-fa3c4dd02cee"
      }
    }
  ],
  "realtime": []
}
  1. Run the server with CONFIGURATION_FILE pointing to the config json file
  2. Insert row to table

Expected behavior

Both realtime subscribers and webhook connectors should work as normal.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

  • OS: macOS
  • Browser: Chrome
  • Version of Node.js: 14.11.0

Additional context

Add any other context about the problem here.

@w3b6x9 w3b6x9 added the bug Something isn't working label Dec 15, 2020
@soedirgo soedirgo linked a pull request Dec 21, 2020 that will close this issue
@soedirgo
Copy link
Member

Closed by #92.

w3b6x9 pushed a commit that referenced this issue Nov 4, 2022
Deploy staging max_concurrent_users limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants