Merge pull request #283 from supabase/BREAK/omit-nullsfirst-nullslast…

…-by-default feat: omit `.nullsfirst`/`.nullslast` by default
supabase · Jun 17, 2022 · 36dfa2f · 36dfa2f
2 parents ae2726b + a1012e8
commit 36dfa2f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/PostgrestTransformBuilder.ts b/src/PostgrestTransformBuilder.ts
@@ -60,7 +60,7 @@ export default class PostgrestTransformBuilder<
     column: string,
     {
       ascending = true,
-      nullsFirst = true,
+      nullsFirst,
       foreignTable,
     }: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}
   ): this {
@@ -69,8 +69,8 @@ export default class PostgrestTransformBuilder<
 
     this.url.searchParams.set(
       key,
-      `${existingOrder ? `${existingOrder},` : ''}${column}.${ascending ? 'asc' : 'desc'}.${
-        nullsFirst ? 'nullsfirst' : 'nullslast'
+      `${existingOrder ? `${existingOrder},` : ''}${column}.${ascending ? 'asc' : 'desc'}${
+        nullsFirst === undefined ? '' : nullsFirst ? '.nullsfirst' : '.nullslast'
       }`
     )
     return this