Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip upserting disabled function #2770

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: skip upserting disabled function #2770

merged 2 commits into from
Oct 16, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 15, 2024 •
edited
Loading

What kind of change does this PR introduce?

relates to #2688

What is the new behavior?

Check in UpsertFunctions if a slug should be skipped.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11356562273

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 60.167%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/deploy/deploy.go 4 5 80.0%
internal/functions/serve/serve.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
internal/functions/deploy/deploy.go 1 83.82%
Totals Coverage Status
Change from base Build 11340569239: -0.04%
Covered Lines: 6504
Relevant Lines: 10810
💛 - Coveralls

@sweatybridge sweatybridge changed the title chore: refactor function enabled check fix: skip upserting disabled function Oct 16, 2024
@sweatybridge sweatybridge merged commit fe0097e into develop Oct 16, 2024
8 checks passed
@sweatybridge sweatybridge deleted the skip-deploy branch October 16, 2024 00:31
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweatybridge @coveralls