Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update path separator for windows glob #2735

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 8, 2024

What kind of change does this PR introduce?

Bug fix #2734

What is the new behavior?

Convert path separator to / on windows.

Additional context

Tested in VM.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11237255781

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 60.216%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11233693811: -0.03%
Covered Lines: 6513
Relevant Lines: 10816

💛 - Coveralls

@sweatybridge sweatybridge merged commit fcd8ea0 into develop Oct 8, 2024
9 checks passed
@sweatybridge sweatybridge deleted the fix-glob branch October 8, 2024 18:45
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.202.4 and later break seed on reset - Windows
2 participants