Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable interactive console when seeding on start #2483

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 2, 2024

What kind of change does this PR introduce?

follow up #2460

What is the current behavior?

Broke start with console waiting for input.

What is the new behavior?

Disable interactive console when seeding on start.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner July 2, 2024 13:09
@sweatybridge sweatybridge merged commit 0a1061d into develop Jul 2, 2024
8 checks passed
@sweatybridge sweatybridge deleted the fix-start branch July 2, 2024 13:12
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9761592227

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 61.17%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/seed.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/seed/buckets/buckets.go 1 24.14%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9760405475: -0.02%
Covered Lines: 7056
Relevant Lines: 11535

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants