Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): update GoTrue Image to avoid signup link generation bug #2197

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dagingaa
Copy link
Contributor

What kind of change does this PR introduce?

GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out, and the only fix is to downgrade to an older version.

This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.

What is the current behavior?

The CLI is fixed on GoTrue version 2.145.0 which has a bug related to signup link generation.

What is the new behavior?

The CLI now uses GoTrue version 2.149.0 which does not have a bug related to signup link generation.

Additional context

GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out.

This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.
@dagingaa dagingaa requested a review from a team as a code owner April 22, 2024 09:09
@sweatybridge sweatybridge changed the title Update GoTrue Image to avoid signup link generation bug fix(auth): update GoTrue Image to avoid signup link generation bug Apr 22, 2024
@sweatybridge sweatybridge merged commit 69deec5 into supabase:main Apr 22, 2024
12 checks passed
@dagingaa dagingaa deleted the patch-1 branch April 22, 2024 10:12
@dagingaa
Copy link
Contributor Author

Hey @sweatybridge! I think this commit has disappeared from main. At least I can't for the life of me find it. Should this have been merged to develop instead? In any case, this bug fix is sorely needed, as it breaks signup link generation.

@sweatybridge
Copy link
Contributor

yup, sorry I missed this in the review earlier. It should be merged to develop instead. Do you mind opening again?

@dagingaa dagingaa restored the patch-1 branch April 26, 2024 11:15
@dagingaa
Copy link
Contributor Author

Reopened as #2212

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants