Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialise realtime schema on db start #2169

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: initialise realtime schema on db start #2169

merged 2 commits into from
Apr 16, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 16, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Allows realtime channels to be setup via seed.sql.
Allows RLS on realtime schema to be added via migrations.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner April 16, 2024 10:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8704193483

Details

  • 48 of 52 (92.31%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 57.91%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/start/start.go 46 50 92.0%
Files with Coverage Reduction New Missed Lines %
internal/db/start/start.go 2 88.61%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8702197731: 0.08%
Covered Lines: 6439
Relevant Lines: 11119

💛 - Coveralls

@sweatybridge sweatybridge merged commit fc3bb71 into develop Apr 16, 2024
9 checks passed
@sweatybridge sweatybridge deleted the rt-schema branch April 16, 2024 11:07
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants