Add More OAuth Providers #245
Merged
+559
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2021
|
Slack needs changes. Misconfigured user request |
|
Uppon reading that further it looks like it may be ok. I haven't been able to test this fully as my gotrue environment locally isn't perfect. Maybe @kangmingtay could test this at some point? Also before merge would this need some sort of tests added? |
|
@awalias Thanks! Was my first "big" PR to sup abase so any feedback would be cool. If you want I could try add tests? |
|
@HarryET main feedback would be in future to break them out into separate PRs, that way if slack is buggy, we can still merge spotify etc. but no worries for this one 👍 |
|
🎉 This PR is included in version 2.1.17 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
HarryET
added a commit
to HarryET/gotrue-dart
that referenced
this pull request
Oct 30, 2021
Added in GoTrue PR - supabase/auth#245
HarryET
added a commit
to HarryET/gotrue-swift
that referenced
this pull request
Oct 30, 2021
* Slack * Spotify supabase/auth#245
HarryET
added a commit
to HarryET/gotrue-csharp
that referenced
this pull request
Oct 30, 2021
* Slack * Spotify supabase/auth#245
sealinesun
added a commit
to sealinesun/gotrue-dart
that referenced
this pull request
May 25, 2022
Added in GoTrue PR - supabase/auth#245
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Add More OAuth Providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This adds new requested OAuth providers:
What is the current behavior?
No support for new OAuth Providers
What is the new behavior?
Support for new OAuth Providers
Additional context
https://twitter.com/supabase/status/1451316743859752963