-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSA Public/Private keys #195
Conversation
Hey @Alexays, thanks for taking the initiative to help out with this! Just wanted to let you know that we are not planning to add this for the time being. We definitely plan to support both HS256 (symmetric) and RS256 (asymmetric) encryptions of JWT sometime in the future. It's a good start but the current changes you've made will need some work because we need to ensure that any updates made are backward compatible for the rest of the community using gotrue. In the meantime, I can share with you some thoughts I have at the top of my head regarding how this should be designed / refactored:
We leave this PR open and discuss any design considerations / security implications to take note of. |
Hey @kangmingtay thanks for your response! |
Just a little message to say that it works perfectly, let me know when you want to implement it on master @kangmingtay |
Hey @Alexays, this looks awesome! Could you do me a favor and update your branch with the latest version on master? We just fixed the test suite and it should help in checking if there are any breaking changes. |
Done @kangmingtay! :) |
Any news @kangmingtay ? |
Hey @Alexays, I haven't had the time to test this out yet and play around with it. I've been pretty busy with increasing our test coverage & refactoring parts of gotrue. Will plan to look into this around mid - end October! |
Hey this PR has been outdated for a long while now. I'll close it, but if you still wish to contribute please re-open it or submit a new one! On asymmetric JWTs, we are unable to support an implementation at this time as Supabase's platform relies heavily on symmetric JWTs. We have been discussing some changes to this, but they will be significant and we'll introduce proper support then. |
What kind of change does this PR introduce?
Feature
What is the current behavior?
Using JWT secret only
What is the new behavior?
Can use JWT secret or RSA pub/priv keys
Additional context
I wanted to know if I was going in the right direction to implement this feature before continuing.
Fixes #171