Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce authorized address checks on send email only #1806

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: enforce authorized address checks on send email only #1806

merged 1 commit into from
Oct 15, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Oct 15, 2024

Moves the authorized address only check in the flow that sends the email, instead of in the email address validation flow.

@hf hf requested a review from a team as a code owner October 15, 2024 11:20
@hf hf force-pushed the hf/aao-in-send-email branch 2 times, most recently from bba4ccd to 2324eac Compare October 15, 2024 11:25
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11345250920

Details

  • 10 of 36 (27.78%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 57.082%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/mail.go 10 36 27.78%
Totals Coverage Status
Change from base Build 11334620572: -0.1%
Covered Lines: 9523
Relevant Lines: 16683
💛 - Coveralls

@hf hf force-pushed the hf/aao-in-send-email branch from 2324eac to 173cac1 Compare October 15, 2024 11:37
cstockton
cstockton approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hf hf merged commit c0c5b23 into master Oct 15, 2024
2 checks passed
@hf hf deleted the hf/aao-in-send-email branch October 15, 2024 17:19
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Merged
cstockton pushed a commit that referenced this pull request Oct 15, 2024
@github-actions
chore(master): release 2.163.0 (#1794)
14b375f 
🤖 I have created a release *beep* *boop*
---


##
[2.163.0](v2.162.2...v2.163.0)
(2024-10-15)


### Features

* add mail header support via `GOTRUE_SMTP_HEADERS` with `$messageType`
([#1804](#1804))
([99d6a13](99d6a13))
* add MFA for WebAuthn
([#1775](#1775))
([8cc2f0e](8cc2f0e))
* configurable email and sms rate limiting
([#1800](#1800))
([5e94047](5e94047))
* mailer logging ([#1805](#1805))
([9354b83](9354b83))
* preserve rate limiters in memory across configuration reloads
([#1792](#1792))
([0a3968b](0a3968b))


### Bug Fixes

* add twilio verify support on mfa
([#1714](#1714))
([aeb5d8f](aeb5d8f))
* email header setting no longer misleading
([#1802](#1802))
([3af03be](3af03be))
* enforce authorized address checks on send email only
([#1806](#1806))
([c0c5b23](c0c5b23))
* fix `getExcludedColumns` slice allocation
([#1788](#1788))
([7f006b6](7f006b6))
* Fix reqPath for bypass check for verify EP
([#1789](#1789))
([646dc66](646dc66))
* inline mailme package for easy development
([#1803](#1803))
([fa6f729](fa6f729))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstockton cstockton cstockton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf @coveralls @cstockton