Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admin user update should update is_anonymous field #1623

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

@kangmingtay kangmingtay requested a review from a team as a code owner June 16, 2024 11:12
@coveralls
Copy link

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9535530780

Details

  • 10 of 20 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 57.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/admin.go 10 20 50.0%
Totals Coverage Status
Change from base Build 9517969468: -0.007%
Covered Lines: 8665
Relevant Lines: 15042

💛 - Coveralls

@kangmingtay kangmingtay merged commit f5c6fcd into master Jun 17, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-admin-update-user branch June 17, 2024 09:01
J0 pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.154.1](v2.154.0...v2.154.1)
(2024-06-17)


### Bug Fixes

* add ip based limiter
([#1622](#1622))
([06464c0](06464c0))
* admin user update should update is_anonymous field
([#1623](#1623))
([f5c6fcd](f5c6fcd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@camwest
Copy link

camwest commented Jul 9, 2024

Hey folks, when will this be put into production? I see my linked project on supabase is still using v2.152.1

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?
* Fixes supabase#1578
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.154.1](supabase/auth@v2.154.0...v2.154.1)
(2024-06-17)


### Bug Fixes

* add ip based limiter
([supabase#1622](supabase#1622))
([06464c0](supabase@06464c0))
* admin user update should update is_anonymous field
([supabase#1623](supabase#1623))
([f5c6fcd](supabase@f5c6fcd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.154.1](supabase/auth@v2.154.0...v2.154.1)
(2024-06-17)


### Bug Fixes

* add ip based limiter
([supabase#1622](supabase#1622))
([06464c0](supabase@06464c0))
* admin user update should update is_anonymous field
([supabase#1623](supabase#1623))
([f5c6fcd](supabase@f5c6fcd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.154.1](supabase/auth@v2.154.0...v2.154.1)
(2024-06-17)


### Bug Fixes

* add ip based limiter
([supabase#1622](supabase#1622))
([06464c0](supabase@06464c0))
* admin user update should update is_anonymous field
([supabase#1623](supabase#1623))
([f5c6fcd](supabase@f5c6fcd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateUser vs admin.updateUserById behavior with Anonymous Users
5 participants