-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With email verification disabled in my project, email verification is still required in order to promote an anonymous user #1619
Comments
hey @symbolpunk,
can you elaborate on why this is a blocker for migrating from Firebase?
This is the current limitation and we're working to see how this can be improved. Currently, an anonymous user will need to verify the email change first before calling
yeah, it doesn't respect the email verification disabled config and this seems like a bug - i'll check with the team if there are any concerns before making a fix for this |
This is a blocker for projects that want minimal friction, which is the purpose of anonymous logins |
Thanks @kangmingtay -
We require seamless migration without introducing breaking changes to the user experience or a significant amount of additional "work" for devs. Firebase lets us promote anon to non-anon without email verification.
Great, thanks for acknowledging. It might be worth updating the docs & blog post in the meantime, so as not to lead teams astray who assume "absence of limitation disclosure" == "absence of limitation", which is the assumption that I made.
Wonderful, thank you again! |
Related: #1578 |
hey @symbolpunk and @NodeAdam, this took some time as the team was quite tight on bandwidth, but i've just put a PR up for it, thanks for reporting this! |
## What kind of change does this PR introduce? * `GOTRUE_MAILER_AUTOCONFIRM` setting should be respected in the update email flow via `PUT /user` ## What is the current behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email still sends an email and requires user confirmation * Difficult for anonymous users to upgrade to a permanent user seamlessly without requiring email confirmation * Fixes #1619 ## What is the new behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email will not require email confirmation. ## Additional context Add any other context or screenshots.
Thank you so much for this @kangmingtay 🙏 |
) ## What kind of change does this PR introduce? * `GOTRUE_MAILER_AUTOCONFIRM` setting should be respected in the update email flow via `PUT /user` ## What is the current behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email still sends an email and requires user confirmation * Difficult for anonymous users to upgrade to a permanent user seamlessly without requiring email confirmation * Fixes supabase#1619 ## What is the new behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email will not require email confirmation. ## Additional context Add any other context or screenshots.
) ## What kind of change does this PR introduce? * `GOTRUE_MAILER_AUTOCONFIRM` setting should be respected in the update email flow via `PUT /user` ## What is the current behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email still sends an email and requires user confirmation * Difficult for anonymous users to upgrade to a permanent user seamlessly without requiring email confirmation * Fixes supabase#1619 ## What is the new behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email will not require email confirmation. ## Additional context Add any other context or screenshots.
) ## What kind of change does this PR introduce? * `GOTRUE_MAILER_AUTOCONFIRM` setting should be respected in the update email flow via `PUT /user` ## What is the current behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email still sends an email and requires user confirmation * Difficult for anonymous users to upgrade to a permanent user seamlessly without requiring email confirmation * Fixes supabase#1619 ## What is the new behavior? * When `GOTRUE_MAILER_AUTOCONFIRM=true`, updating a user's email will not require email confirmation. ## Additional context Add any other context or screenshots.
Bug report
Describe the bug
With email verification disabled in my project, email verification is still required in order to promote an anonymous user (created via
signInAnonymously
) to a non-anonymous user (viaauth.updateUser({ email })
.To Reproduce
auth.signInAnonymously()
.auth.updateUser({ email })
per instructions found in your docs and blog post.Expected behavior
Additional context
auth.updateUser({ password })
per your docs, after attempting theauth.updateUser({ email })
call.updateUser
flow appears to write the suppliedemail
toemail_change
instead ofemail
on the anonymous user's row in theauth.users
table.email
andemail_confirmed_at
accordingly, while triggering whatever additional business logic is required to promote the anonymous user, without emitting an email or requiring email verification.The text was updated successfully, but these errors were encountered: