-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement Admin API User functions and Refactor Test Suite #195
Conversation
Once the PR is approved will need to update the admin docs for:
|
Note: the
But, the only filter currently is I'll make a separate issue for adding filter support to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Regarding #195 (comment) I think it's fine to keep it named listUsers and add the filters in there e.g. listUsers({ email, limit })
etc.
@kangmingtay Made some mods and tried to answer your questions and hope resolved so can be merged. Thanks! |
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
The PR is twofold:
Fixes #190
Fixes #191
Fixes #187
1 - Implements Issue #190 to allow admin api to
What is the current behavior?
2 - The test suite
a) lacked coverage
b) was confusing to see coverage because was scenario driven (sign up enabled/disabled) and mixed auth and service api methods in the tests)
c) did not work well with test tools like [Wallaby[(https://wallabyjs.com) as the test had to be run sequentially due to the way emails and password were generated to create test users
What is the new behavior?
GoTrueApi
GoTrueClient
Test Results
Additional context
Note: May still need some more enabled/disabled scenario tests and also have one disabled verifyOTP() test