fix: supabase/supabase-js#178 handle JWT expiry <= 60s #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on fire @thebengeu 🔥 |
awalias
approved these changes
Jun 14, 2021
|
looks like there is some failing check https://github.com/supabase/gotrue-js/pull/101/checks?check_run_id=2816594247#step:4:49 |
|
Fixed. |
|
legend, thanks @thebengeu |
|
🎉 This PR is included in version 1.16.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Handles JWT expiry <= 60s correctly.
What is the current behavior?
#620: Refresh token doesn't update when JWT expiry is set to 60, constantly updates when JWT expiry is set to less than 60 since
expiresAt - timeNow - 60is negative.What is the new behavior?
When JWT expiry is set to more than 60, current behavior remains to refresh 60s before expiry. When JWT expiry is set to 60 or less, new behavior is to refresh 0.5s before expiry.
Additional context
0.5s is chosen to support JWT expiry of 1s, even though that should be an edge case. That should usually still be enough time to reach the server before expiry.