Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failed to parse cookie string in middleware #532

Merged
merged 1 commit into from
May 4, 2023

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When using the createMiddlewareSupabaseClient inside a middleware the storage driver would throw an error due to the cookie being saved twice.

What is the new behavior?

There is no longer an error and cookie is only saved once.

Additional context

Add any other context or screenshots.

@silentworks silentworks merged commit 165ba70 into next May 4, 2023
@silentworks silentworks deleted the bugfix/failed-to-parse-cookie-string branch May 4, 2023 19:26
@jlfwong
Copy link

jlfwong commented May 18, 2023

Hi! We ran into this while working on https://streamlineclimate.com/. We have workarounds for now, but would love to have this fixed upstream. Is there an ETA on an npm publish that includes this change?

CC @douglasqian

@silentworks
Copy link
Contributor Author

This is already published on npm on the .next release. We are working to get a final release out soon, but currently we need to update the docs before we can make this a final release.

silentworks added a commit that referenced this pull request May 25, 2023
* Update changeset config and git workflow

* Update to ci pipeline latest LTS nodejs

* Storage adapter (#507)

* add storage adapters

* Remove unused filterCookies function

* add pkce support

* update sveltekit example

* Add pre-release changeset

* Bump SvelteKit version

---------

Co-authored-by: David Plugge <[email protected]>

* chore: update versions (next) (#508)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* simplifying defaults for storage adapter (#510)

* chore: update versions (next) (#511)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* remove unused type (#512)

* remove unused type

* add changeset

* chore: update versions (next) (#513)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: add jose to .next branch (#526)

* Add jose for it's base64url decode support

* Remove js-base64 becuase buffer check Vercel issue

* chore: update versions (next) (#527)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix Failed to parse cookie string in middleware (#532)

* chore: update versions (next) (#533)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix cookie saving in middleware/routeHandler (#536)

* chore: update versions (next) (#537)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* add lint and format scripts (#538)

* change prettier config
* format md files with spaces
* add husky and pre-commit script
* add lint-staged
* configure lint-staged
* use tsc as linter
* add ci workflow
* add checks permission
* use prettierignore

* WIP: Writable cookies (#543)

* wip: example for writable cookies - server actions and route handlers

* add ReadonlyRequestCookies type for Server Component client

* swap routeHandler and serverActions client (#544)

* Chore: Implement naming convention for createClient functions (#547)

* implement consistent naming convention for createClient functions

* Add deprecated functions and changeset

---------

Co-authored-by: Andrew Smith <[email protected]>

* chore: update versions (next) (#548)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Ignore changeset and github actions

* Chore: Implement singleton pattern for createClientComponentClient function (#550)

* implement singleton pattern for createClientComponentClient

* Fix type issue (#554)

* Fix: Set response cookie (#551)

* add cookie header to make refreshed session available in Server Components

* add guard around setting headers

* Chore: Update Next.js and remove custom type for WritableCookies (#552)

* update next.js and remove custom type

* chore: update versions (next) (#555)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix: Typedefs for clientClient functions (#556)

* add explicit return types for createClient functions

* add deprecated functions for App Router createClient functions

* add changeset

* Fix: missing type from SvelteKit and remix package (#557)

* chore: update versions (next) (#558)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Final release of auth-helpers PKCE

* chore: update versions (#559)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: David Plugge <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Plugge <[email protected]>
Co-authored-by: Jon Meyers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants