don't catch errors in user handlers #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-type terribly sorry, this slipped through the cracks in the lead-up to Launch Week 🙈 I was wondering, would you be up for also doing https://github.com/supabase-community/supabase-auth-helpers/issues/59 within this PR? |
|
I'd prefer to leave it as-is, honestly - I didn't end up using Supabase as an auth provider, just wanted to contribute toward one pain point I had in trying it out, but I've had to move on to other work. |
|
Adressed in #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves code which invokes logic defined by the library user outside of the try-catch blocks, so that errors in user-written code are handled (or not) as normally expected by Next.
I'm a little unfamiliar with Next middleware so I'm not confident my moving of
NextResponse.nextwas quite correct, let me know.