Handle weak_password and session_not_found auth error codes
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
approved these changes
May 16, 2024
|
Hi @jan-tennert not sure if you're aware but this error codes are part of a bigger initiative, maybe you wan't to add overall support for error codes before merging this? Check supabase/auth-js#855 |
|
Do you mean checking for the API version? Currently, a pretty generic exception gets thrown like |
|
Going to merge this for now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature (closes #592)
What is the current behavior?
No API error is handled internally.
What is the new behavior?
The error codes
weak_passwordandsession_not_foundnow get handled internally. Both throw their own exception (from the base classAuthRestException), the first one includes the reasons and the second causes the session to be cleared.