Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function arguments to take T: ToString #3

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

sunsided
Copy link
Owner

@sunsided sunsided commented May 23, 2024

Implements a solution for #2. With this (breaking) change, any displayable type can now be used directly:

let qs = QueryString::new()
            .with_value("q", "🍎 apple")
            .with_value("category", "fruits and vegetables")
            .with_value("weight", 42)
            .with_opt_value("tasty", Some(true));

@sunsided sunsided self-assigned this May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (657407d) to head (d6faf3a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          178       174    -4     
=========================================
- Hits           178       174    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunsided sunsided merged commit a55ec24 into main May 24, 2024
6 checks passed
@sunsided sunsided deleted the feature/tostring branch May 24, 2024 08:11
@sunsided sunsided changed the title Change function argements to take T: ToString Change function arguments to take T: ToString May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant