Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra fix for card paths #264

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Extra fix for card paths #264

merged 1 commit into from
Aug 7, 2024

Conversation

nabobalis
Copy link
Contributor

No description provided.

@@ -8,7 +8,7 @@ Cards
******

.. custom-card:: Stuart Mumford
:img_name: Stuart-Mumford.png
:img_name: _static/img/Stuart-Mumford.png
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the full path for this going forward.

<p>{node['name']}</p>
<p><button type="button" class="btn btn-sunpy btn-sunpy1" data-bs-toggle="modal" data-bs-target="#{key}">More Info</button></p>
<p><button type="button" class="btn btn-sunpy btn-sunpy1 stretched-link" data-bs-toggle="modal" data-bs-target="#{key}">More Info</button></p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to see if this makes the whole card clickable.

@nabobalis nabobalis marked this pull request as ready for review August 7, 2024 15:50
@nabobalis nabobalis merged commit f4da503 into main Aug 7, 2024
3 of 7 checks passed
@nabobalis nabobalis deleted the fix branch August 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant