Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› Unable to switch to a namespace #856

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

sunny0826
Copy link
Owner

βœ… Closes: #749

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@the-label-bot the-label-bot bot added kind/bug Something isn't working size/L size/L labels Jan 15, 2024
Copy link

the-label-bot bot commented Jan 15, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind bug 0.794 βœ”οΈ
Size L 0.975 βœ”οΈ

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (750debc) 18.81% compared to head (051db28) 19.28%.

Files Patch % Lines
cmd/namespace.go 40.00% 29 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   18.81%   19.28%   +0.47%     
==========================================
  Files          21       21              
  Lines        2264     2271       +7     
==========================================
+ Hits          426      438      +12     
+ Misses       1798     1792       -6     
- Partials       40       41       +1     
Flag Coverage Ξ”
unittests 19.28% <40.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@sunny0826 sunny0826 merged commit 5cd1b02 into master Jan 15, 2024
6 checks passed
@sunny0826 sunny0826 deleted the bug/switch-namespace branch January 15, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/L size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to switch to a namespace as I have no permissions to list namespaces
1 participant