Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 get export env KUBECONFIG #855

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

sunny0826
Copy link
Owner

Description

get export env KUBECONFIG

Related Issue

resolves #850

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@the-label-bot the-label-bot bot added kind/feature ategorizes issue or PR as related to a new feature. size/S size/S labels Jan 15, 2024
Copy link

the-label-bot bot commented Jan 15, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.576 ✔️
Size S 0.984 ✔️

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (786b5ef) 18.84% compared to head (db8ba48) 18.81%.

Files Patch % Lines
cmd/root.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   18.84%   18.81%   -0.04%     
==========================================
  Files          21       21              
  Lines        2260     2264       +4     
==========================================
  Hits          426      426              
- Misses       1794     1798       +4     
  Partials       40       40              
Flag Coverage Δ
unittests 18.81% <14.28%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunny0826 sunny0826 merged commit 750debc into master Jan 15, 2024
6 checks passed
@sunny0826 sunny0826 deleted the feat/get-config-from-env branch January 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature. size/S size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export kubeconfig causes nil pointer
1 participant