Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add --insecure-skip-tls-verify when executing kubecm add #1045

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mayooot
Copy link

@mayooot mayooot commented Dec 24, 2024

Description

Add --insecure-skip-tls-verify when executing kubecm add

Related Issue

#1041

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

Copy link

the-label-bot bot commented Dec 24, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label

@mayooot mayooot changed the title Feat/insecure skip tls verify [Feature] Add --insecure-skip-tls-verify when executing kubecm add Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 20.26%. Comparing base (00e6c89) to head (ac71185).

Files with missing lines Patch % Lines
cmd/cloud_add.go 0.00% 10 Missing ⚠️
cmd/add.go 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   20.03%   20.26%   +0.23%     
==========================================
  Files          21       21              
  Lines        2601     2615      +14     
==========================================
+ Hits          521      530       +9     
- Misses       2033     2038       +5     
  Partials       47       47              
Flag Coverage Δ
unittests 20.26% <46.42%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant