Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#666): Add builder for non-exhaustive structs #688

Conversation

hadizamani021
Copy link
Contributor

@hadizamani021 hadizamani021 commented Dec 21, 2024

issue (#666)

@hadizamani021 hadizamani021 changed the title Add builder for non-exhaustive structs 666 Add builder for non-exhaustive structs #666 Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Add builder for non-exhaustive structs #666 Fix(#666): Add builder for non-exhaustive structs Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Fix(#666): Add builder for non-exhaustive structs Fix(666): Add builder for non-exhaustive structs Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Fix(666): Add builder for non-exhaustive structs fix(#666): Add builder for non-exhaustive structs Dec 21, 2024
@sunng87
Copy link
Owner

sunng87 commented Dec 23, 2024

@hadizamani021 Thank you! You can use derive_builder crate to generate builders for this case.

@coveralls
Copy link

coveralls commented Dec 23, 2024

Coverage Status

coverage: 82.062% (+0.04%) from 82.024%
when pulling 111cb9f on hadizamani021:feat/add-builder-for-non-exhaustive-structs
into 190bc3b on sunng87:master.

@sunng87
Copy link
Owner

sunng87 commented Dec 24, 2024

LGTM. Is there any other struct to add builder?

@hadizamani021
Copy link
Contributor Author

@sunng87 Thank you sunng, I added for all non_exhaustive structs.

@sunng87
Copy link
Owner

sunng87 commented Dec 25, 2024

@hadizamani021 Thank you!

@sunng87 sunng87 merged commit 891426f into sunng87:master Dec 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants