Stop overriding callback methods if they're present #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skycocker 👋 I like this change! Would you mind adding a bit of test coverage for the new method? If you can get that added, I'll be happy to merge & release. ❤️ |
|
Will this solve the issue here? |
|
@chevinbrown it will, but it has to be done with caution and after reading the readme notes. I'll provide some tests once I find some spare time :) |
|
@skycocker what caution do you mean? 😸 I can merge this and add a followup PR to add test coverage if that suits you? |
This was referenced Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case where a callback method (like
on_friendship_created) is being overridden by an empty method from the template (in removed lines 91-93), if such callback method is defined by e.g. a concern, which is included to the class which useshas_friendshipas well.