feat(components): migrate Select to TypeScript #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/typescript-select
feature/typescript-select
feature/typescript-select
feature/typescript-select feature/typescript-select feature/typescript-select
Making the label required would be a major breaking change that would require a lot of manual work from users since it's not feasible to codemod. Therefore, I've made it a non-breaking change and added a warning to encourage users to update their code. feature/typescript-select
feature/typescript-select
feature/typescript-select
feature/typescript-select feature/typescript-select
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/bmyezw0m7 |
Codecov Report
@@ Coverage Diff @@
## beta #611 +/- ##
==========================================
- Coverage 93.93% 93.92% -0.02%
==========================================
Files 133 134 +1
Lines 2145 2188 +43
Branches 624 629 +5
==========================================
+ Hits 2015 2055 +40
- Misses 106 110 +4
+ Partials 24 23 -1
|
feature/typescript-select
feature/typescript-select
feature/typescript-select
fernandofleury
approved these changes
Jun 11, 2020
|
🎉 This PR is included in version 2.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #516.
Approach and changes
inputOutlinestyle helper (used across Select, Input, TextArea, Selector)Before
After
Definition of done