Remove custom initial focus logic #2910
Merged
+15
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/DSYS-878/remove-react-modal #2910 +/- ##
=================================================================
Coverage 88.10% 88.11%
=================================================================
Files 222 221 -1
Lines 12922 12868 -54
Branches 1788 1781 -7
=================================================================
- Hits 11385 11338 -47
+ Misses 1484 1477 -7
Partials 53 53
|
|
Size Change: -393 B (-0.06%) Total Size: 676 kB
ℹ️ View Unchanged
|
sirineJ
approved these changes
Jan 24, 2025
connor-baer
merged commit 4d0c3ee
into
feat/DSYS-878/remove-react-modal
12 checks passed
sirineJ
pushed a commit
that referenced
this pull request
Jan 24, 2025
sirineJ
pushed a commit
that referenced
this pull request
Jan 28, 2025
sirineJ
pushed a commit
that referenced
this pull request
Feb 28, 2025
sirineJ
added a commit
that referenced
this pull request
Mar 3, 2025
* split preventClose into 3 different props * refactor side panel with dialog * add backButtonLabel default translations * delete old ModalContext * remove react-modal dependency * refactor: split effects * refactor: dialog props * code review * restore group prop * remove visibility from animations * fix use of refs * fixup! remove visibility from animations * early returns * fix focus issue * Fix Dialog's server-side rendering compat * Simplify Modal JSX * Remove custom initial focus logic (#2910) * fix animation * fix test name * remove isMobile prop * fix props preview in docs * handle escape key events triggered from outside the dialog. * only restore focus to trigger element if focus is within the dialog * update docs * dialog fix * fix sync issues * remove inline use from docs * changes after rebase * increase specificity of the close button --------- Co-authored-by: Connor Bär <[email protected]> Co-authored-by: Connor Bär <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Browsers (and the dialog-polyfill) already handle focusing the first interactive element inside a
dialogelement when opened.Approach and changes
initialFocusRefprop with the nativeautofocusattribute. React (purposefully 🙄) breaks theautoFocusproperty (see autofocus attr not included in button element when rendered facebook/react#11851 (comment)), so we have to work around that by using the lowercase attribute name with a string value to force React to serialize it to the DOM (see Bug: autoFocus broken inside <dialog /> facebook/react#23301). This produces a console warning that can be safely ignored.Definition of done