Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @sumup/collector #1972

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Remove @sumup/collector #1972

merged 3 commits into from
Apr 22, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Mar 2, 2023

Addresses DSYS-372. Relates to #1997.

Purpose

@sumup/collector has been deprecated. Circuit UI deprecated the tracking prop integration in #1997. Developers should use event handlers to dispatch user interaction events instead.

Approach and changes

  • Remove @sumup/collector from the peer dependencies
  • Remove the tracking and trackingLabel props

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

🦋 Changeset detected

Latest commit: 2e65ed2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/circuit-ui Major
@sumup/cna-template Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2023 8:48pm

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1972 (2e65ed2) into next (0b7fb45) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1972      +/-   ##
==========================================
- Coverage   92.17%   92.13%   -0.05%     
==========================================
  Files         168      166       -2     
  Lines        3542     3459      -83     
  Branches     1220     1188      -32     
==========================================
- Hits         3265     3187      -78     
+ Misses        256      254       -2     
+ Partials       21       18       -3     
Impacted Files Coverage Δ
packages/circuit-ui/components/Button/Button.tsx 93.84% <ø> (-0.10%) ⬇️
...ackages/circuit-ui/components/Carousel/Carousel.js 100.00% <ø> (ø)
...ckages/circuit-ui/components/Checkbox/Checkbox.tsx 86.20% <ø> (-0.46%) ⬇️
...ages/circuit-ui/components/Hamburger/Hamburger.tsx 88.57% <ø> (-0.32%) ⬇️
...ckages/circuit-ui/components/ListItem/ListItem.tsx 94.93% <ø> (-0.07%) ⬇️
...ircuit-ui/components/ModalContext/ModalContext.tsx 90.69% <ø> (-0.97%) ⬇️
...mponents/NotificationBanner/NotificationBanner.tsx 86.44% <ø> (+2.56%) ⬆️
...mponents/NotificationInline/NotificationInline.tsx 96.29% <ø> (+3.31%) ⬆️
...components/NotificationToast/NotificationToast.tsx 97.72% <ø> (+4.11%) ⬆️
.../circuit-ui/components/RadioButton/RadioButton.tsx 90.90% <ø> (-0.40%) ⬇️
... and 26 more

... and 1 file with indirect coverage changes

@connor-baer connor-baer changed the base branch from main to next March 16, 2023 08:28
@connor-baer connor-baer added this to the v7.0 milestone Mar 16, 2023
@connor-baer connor-baer requested a review from robinmetral March 16, 2023 08:29
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹🗑️

Only thing here is that next and main diverged after #1997. How do you want to resolve this?

@connor-baer connor-baer force-pushed the feature/remove-collector branch from 8798b71 to 2e65ed2 Compare April 22, 2023 20:45
@connor-baer connor-baer marked this pull request as ready for review April 22, 2023 20:45
@connor-baer connor-baer requested a review from a team as a code owner April 22, 2023 20:45
@connor-baer connor-baer merged commit 0f29f87 into next Apr 22, 2023
@connor-baer connor-baer deleted the feature/remove-collector branch April 22, 2023 20:56
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants