-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @sumup/collector #1972
Remove @sumup/collector #1972
Conversation
🦋 Changeset detectedLatest commit: 2e65ed2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #1972 +/- ##
==========================================
- Coverage 92.17% 92.13% -0.05%
==========================================
Files 168 166 -2
Lines 3542 3459 -83
Branches 1220 1188 -32
==========================================
- Hits 3265 3187 -78
+ Misses 256 254 -2
+ Partials 21 18 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹🗑️
Only thing here is that next
and main
diverged after #1997. How do you want to resolve this?
8798b71
to
2e65ed2
Compare
Addresses DSYS-372. Relates to #1997.
Purpose
@sumup/collector
has been deprecated. Circuit UI deprecated thetracking
prop integration in #1997. Developers should use event handlers to dispatch user interaction events instead.Approach and changes
@sumup/collector
from the peer dependenciestracking
andtrackingLabel
propsDefinition of done