forked from forkcms/forkcms
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork6 #372
Open
daphneslootmans
wants to merge
70
commits into
sumocoders:fork6
Choose a base branch
from
forkcms:fork6
base: fork6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fork6 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move logic from button and input to input-group
If there is no test database yet a new one will be created, this will also happen if the environment variable TEST_DATABASE is set to fresh instead of cached. After creating the database fork will be installed in the test database
…r a backend action
…roper error message
Add ToggleSecret to backend scripts
* Setup ci pipeline configs * Update necessary npm packages * Refactor long lines * Ignore long lines where it would be more confusing/unreadable to split it up * Ignore fork5 for standard issues * Ignore src.fork5 in stylelint * Fix twigcs issues * Fix npm audit issues * Fix stylelint issues * Use correct file name for stylelintignore * Remove typo * Only ignore files to lon for ForkIntlExtension and RequirementsChecker * Use the official phpcs ruleset * Fix twigcs issues * Remove phpcs-report.xml * Ignore phpcs-report.xml * use data_grids * Use add_item_link_extra_attributes * Use correct variable name for workingLocale * Use css_files * Use js_files * Ignore everything except css and scss * Remove deprecated editor * Use different parameter name for application * Remove the dead code and update the TODO * Use tabstype instead off md5 * Use is_sub_navigation * Use theme_install_form * Add empty line * Add todo * Use variable for key * Use installed_themes twig variable * Use the installable_themes variable * Use correct name for crud_delete_action * Check if the link to users is visible * Check if th elink to users is visible
* Update symfony packages to symfony 6.4 * Fix issue with block editor loading too fast till it is replaced * Default webpack environment to prod * Upgrade to php 8.2 * Fix deprecation warnings while running webpack * Debug failing test on github They work fine locally * fixup! Upgrade to php 8.2
* basic installable module * ContentBlock add * DataGrid * update ContentBlock * save setting 'label' in frontend_blocks and use that when adding block to a page * pass contentblock id to widget * feedback pt 1 * update widget after saving ContentBlock * set locale for widget * parse detail * show content block name on pages module * use trans for revision block label * remove unused methods, always add delete form to edit page * phpstan * remove unused form template * remove auto-generated return phpdoc * enum values in uppercase * remove updateWidget service and move to ContentBlockRepository * remove todo * typo in response * typo in CreateContentBlock * installer: put ContentBlocks under Modules * ContentBlock entity not final * hide frontend block when ContentBlock is hidden or deleted * add traits: Blameable, Locale, Settings * remove unnecessary save call * Revisions + archive other active contentblocks after editing from revision * feedback: remove comments, unused code, change id to content_block_id * add check whether ContentBlock is used on active page and disable delete button if so * ignore ContentBlocks * remove contentblock + remove RevisionBlock from archived page revisions * remove unused repository * add id attribute + change class name * enum values in uppercase * remove doctrine.yml from config * Fix urls not working * Fix blamable in content blocks module * Fix casing content blocks enum * Throw events for the actions happening on content blocks * Make sure the widget is always updated when a content block changes * Make the event dispatcher available in module actions * Use events to handle interaction with frontent blocks across modules * Better notification messages * Implement default visualisation of booleans in datagrids * Add missing content block translations * DataGrid Form Type to show revisions * Implement ContentBlock revisions more cleanly * Make it possible to choose a different template to render a content block * Add functional tests for the content blocks module * Fix delete form showing when content block is in use * Code style fixes --------- Co-authored-by: Jelmer Prins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with upstream